fs/proc/task_mmu.c: simplify the vma_stop() logic
m_start() drops ->mmap_sem and does mmput() if it retuns vsyscall
vma. This is because in this case m_stop()->vma_stop() obviously
can't use gate_vma->vm_mm.
Now that we have proc_maps_private->mm we can simplify this logic:
  - Change m_start() to return with ->mmap_sem held unless it returns
    IS_ERR_OR_NULL().
  - Change vma_stop() to use priv->mm and avoid the ugly vma checks,
    this makes "vm_area_struct *vma" unnecessary.
  - This also allows m_start() to use vm_stop().
  - Cleanup m_next() to follow the new locking rule.
    Note: m_stop() looks very ugly, and this temporary uglifies it
    even more. Fixed by the next change.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: 
Oleg Nesterov <oleg@redhat.com>
Acked-by: 
Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: 
Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: 
Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: 
Linus Torvalds <torvalds@linux-foundation.org>
Loading
Please register or sign in to comment