Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52d0a2ed authored by Rahul Sharma's avatar Rahul Sharma
Browse files

drm/msm/shd: fix missing return value 



Check to validate return value of drm_atomic_set_mode_for_crtc
and print the error log if non-zero value is returned which
indicates failure.

Change-Id: I6a21b9ec64e9140b314dc52a34c6be8b385c6584
Signed-off-by: default avatarRahul Sharma <rahsha@codeaurora.org>
parent fa96a4c8

drivers/gpu/drm/msm/shd/shd_drm.c

+9 −1
Original line number Diff line number Diff line
@@ -241,6 +241,7 @@ static void shd_display_enable_base(struct drm_device *dev, 
	struct drm_connector *connector;

	struct drm_crtc_state *crtc_state;

	struct drm_connector_state *conn_state;

	int ret;



	SDE_DEBUG("enable base display %d\n", base->intf_idx);
@@ -273,7 +274,12 @@ static void shd_display_enable_base(struct drm_device *dev, 
	conn_state->best_encoder = base->encoder;

	connector->encoder = base->encoder;



	drm_atomic_set_mode_for_crtc(crtc_state, &base->mode);

	ret = drm_atomic_set_mode_for_crtc(crtc_state, &base->mode);

	if (ret) {

		SDE_ERROR("failed to set mode for crtc\n");

		goto out;

	}



	drm_mode_copy(&crtc_state->adjusted_mode, &base->mode);

	drm_mode_copy(&base->crtc->mode, &base->mode);
@@ -323,6 +329,8 @@ static void shd_display_enable_base(struct drm_device *dev, 


	base->enabled = true;

	base->enable_changed = true;

out:

	return;

}



static void shd_display_disable_base(struct drm_device *dev,