Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 061029eb authored by Rama Krishna Phani A's avatar Rama Krishna Phani A
Browse files

msm: pcie: Add proper check before accessing variables 



Base_sel variable is being accessed with out any check.
Add proper check before accessing base_sel variable.

Change-Id: I31232cc0285bc8cc01d8fa4ee7954bf2f766cbce
Signed-off-by: default avatarRama Krishna Phani A <rphani@codeaurora.org>
parent b1d39b55

drivers/pci/host/pci-msm.c

+6 −4
Original line number Diff line number Diff line
@@ -1638,6 +1638,11 @@ static void msm_pcie_sel_debug_testcase(struct msm_pcie_dev_t *dev, 


		break;

	case MSM_PCIE_DUMP_PCIE_REGISTER_SPACE:

		if (!base_sel) {

			PCIE_DBG_FS(dev, "Invalid base_sel: 0x%x\n", base_sel);

			break;

		}



		if (((base_sel - 1) >= MSM_PCIE_MAX_RES) ||

					(!dev->res[base_sel - 1].resource)) {

			PCIE_DBG_FS(dev, "PCIe: RC%d Resource does not exist\n",
@@ -1645,10 +1650,7 @@ static void msm_pcie_sel_debug_testcase(struct msm_pcie_dev_t *dev, 
			break;

		}



		if (!base_sel) {

			PCIE_DBG_FS(dev, "Invalid base_sel: 0x%x\n", base_sel);

			break;

		} else if (base_sel - 1 == MSM_PCIE_RES_PARF) {

		if (base_sel - 1 == MSM_PCIE_RES_PARF) {

			pcie_parf_dump(dev);

			break;

		} else if (base_sel - 1 == MSM_PCIE_RES_PHY) {