Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa7d75f6 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Greg Kroah-Hartman
Browse files

ovl: fix format of setxattr debug 



commit 1a8f8d2a upstream.

Format has a typo: it was meant to be "%.*s", not "%*s".  But at some point
callers grew nonprintable values as well, so use "%*pE" instead with a
maximized length.

Reported-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Fixes: 3a1e819b ("ovl: store file handle of lower inode on copy up")
Cc: <stable@vger.kernel.org> # v4.12
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8d75ecc1

fs/overlayfs/overlayfs.h

+2 −2
Original line number Diff line number Diff line
@@ -136,8 +136,8 @@ static inline int ovl_do_setxattr(struct dentry *dentry, const char *name, 
				  const void *value, size_t size, int flags)

{

	int err = vfs_setxattr(dentry, name, value, size, flags);

	pr_debug("setxattr(%pd2, \"%s\", \"%*s\", 0x%x) = %i\n",

		 dentry, name, (int) size, (char *) value, flags, err);

	pr_debug("setxattr(%pd2, \"%s\", \"%*pE\", %zu, 0x%x) = %i\n",

		 dentry, name, min((int)size, 48), value, size, flags, err);

	return err;

}