Commit 8d75ecc1 authored Sep 18, 2018 by Amir Goldstein Committed by Greg Kroah-Hartman Oct 10, 2018

ovl: fix memory leak on unlink of indexed file



commit 63e13252 upstream.

The memory leak was detected by kmemleak when running xfstests
overlay/051,053

Fixes: caf70cb2 ("ovl: cleanup orphan index entries")
Cc: <stable@vger.kernel.org> # v4.13
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent be406434

fs/overlayfs/util.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -438,7 +438,7 @@ static void ovl_cleanup_index(struct dentry *dentry)
		struct dentry *upperdentry = ovl_dentry_upper(dentry);
		struct dentry *index = NULL;
		struct inode *inode;
		struct qstr name;
		struct qstr name = { };
		int err;

		err = ovl_get_index_name(lowerdentry, &name);
		@@ -477,6 +477,7 @@ static void ovl_cleanup_index(struct dentry *dentry)
		goto fail;

		out:
		kfree(name.name);
		dput(index);
		return;