Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63e13252 authored by Amir Goldstein's avatar Amir Goldstein Committed by Miklos Szeredi
Browse files

ovl: fix memory leak on unlink of indexed file 



The memory leak was detected by kmemleak when running xfstests
overlay/051,053

Fixes: caf70cb2 ("ovl: cleanup orphan index entries")
Cc: <stable@vger.kernel.org> # v4.13
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 6bf4ca7f

fs/overlayfs/util.c

+2 −1
Original line number Diff line number Diff line
@@ -683,7 +683,7 @@ static void ovl_cleanup_index(struct dentry *dentry) 
	struct dentry *upperdentry = ovl_dentry_upper(dentry);

	struct dentry *index = NULL;

	struct inode *inode;

	struct qstr name;

	struct qstr name = { };

	int err;



	err = ovl_get_index_name(lowerdentry, &name);
@@ -726,6 +726,7 @@ static void ovl_cleanup_index(struct dentry *dentry) 
		goto fail;



out:

	kfree(name.name);

	dput(index);

	return;