Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c01513b4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

eeprom: idt_89hpesx: clean up an error pointer vs NULL inconsistency 



We check for IS_ERR_OR_NULL() here, but later we check the same thing
for NULL only.  It turns out that it can only be NULL so we can make the
checking consistent by removing the ERR_PTR stuff.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 81ae962d

drivers/misc/eeprom/idt_89hpesx.c

+1 −1
Original line number Diff line number Diff line
@@ -1128,7 +1128,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) 


	device_for_each_child_node(dev, fwnode) {

		ee_id = idt_ee_match_id(fwnode);

		if (IS_ERR_OR_NULL(ee_id)) {

		if (!ee_id) {

			dev_warn(dev, "Skip unsupported EEPROM device");

			continue;

		} else