Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81ae962d authored by Anton Vasilyev's avatar Anton Vasilyev Committed by Greg Kroah-Hartman
Browse files

misc: ti-st: Fix memory leak in the error path of probe() 



Free resources instead of direct return of the error code if kim_probe
fails.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8c64b39

drivers/misc/ti-st/st_kim.c

+2 −2
Original line number Diff line number Diff line
@@ -755,14 +755,14 @@ static int kim_probe(struct platform_device *pdev) 
	err = gpio_request(kim_gdata->nshutdown, "kim");

	if (unlikely(err)) {

		pr_err(" gpio %d request failed ", kim_gdata->nshutdown);

		return err;

		goto err_sysfs_group;

	}



	/* Configure nShutdown GPIO as output=0 */

	err = gpio_direction_output(kim_gdata->nshutdown, 0);

	if (unlikely(err)) {

		pr_err(" unable to configure gpio %d", kim_gdata->nshutdown);

		return err;

		goto err_sysfs_group;

	}

	/* get reference of pdev for request_firmware

	 */