Commit 9d8009de authored Jul 27, 2018 by Jia-Ju Bai Committed by David S. Miller Jul 26, 2018

isdn: mISDN: netjet: Replace GFP_ATOMIC with GFP_KERNEL in nj_probe()



nj_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8c957d66

drivers/isdn/hardware/mISDN/netjet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1084,7 +1084,7 @@ nj_probe(struct pci_dev pdev, const struct pci_device_id ent)
		return -ENODEV;
		}

		card = kzalloc(sizeof(struct tiger_hw), GFP_ATOMIC);
		card = kzalloc(sizeof(struct tiger_hw), GFP_KERNEL);
		if (!card) {
		pr_info("No kmem for Netjet\n");
		return err;