Commit 8c957d66 authored Jul 27, 2018 by Jia-Ju Bai Committed by David S. Miller Jul 26, 2018

isdn: mISDN: hfcpci: Replace GFP_ATOMIC with GFP_KERNEL in hfc_probe()



hfc_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ff7b9126

drivers/isdn/hardware/mISDN/hfcpci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2220,7 +2220,7 @@ hfc_probe(struct pci_dev pdev, const struct pci_device_id ent)
		struct hfc_pci *card;
		struct _hfc_map m = (struct _hfc_map )ent->driver_data;

		card = kzalloc(sizeof(struct hfc_pci), GFP_ATOMIC);
		card = kzalloc(sizeof(struct hfc_pci), GFP_KERNEL);
		if (!card) {
		printk(KERN_ERR "No kmem for HFC card\n");
		return err;