Commit 8bbafed8 authored Jul 17, 2018 by Hanna Hawa Committed by Vinod Koul Jul 20, 2018

dmaengine: mv_xor_v2: kill the tasklets upon exit



The mv_xor_v2 driver uses a tasklet, initialized during the probe()
routine. However, it forgets to cleanup the tasklet using
tasklet_kill() function during the remove() routine, which this patch
fixes. This prevents the tasklet from potentially running after the
module has been removed.

Fixes: 19a340b1 ("dmaengine: mv_xor_v2: new driver")

Signed-off-by: Hanna Hawa <hannah@marvell.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 48c008b5

drivers/dma/mv_xor_v2.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -903,6 +903,8 @@ static int mv_xor_v2_remove(struct platform_device *pdev)

	platform_msi_domain_free_irqs(&pdev->dev);		platform_msi_domain_free_irqs(&pdev->dev);

			tasklet_kill(&xor_dev->irq_tasklet);

	clk_disable_unprepare(xor_dev->clk);		clk_disable_unprepare(xor_dev->clk);

	return 0;		return 0;