Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48c008b5 authored by Hanna Hawa's avatar Hanna Hawa Committed by Vinod Koul
Browse files

dmaengine: mv_xor_v2: explicitly freeup irq 



dmaengine device should explicitly call devm_free_irq() when using
devm_request_irq().

The irq is still ON when devices remove is executed and irq should be
quiesced before remove is completed.

Signed-off-by: default avatarHanna Hawa <hannah@marvell.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent ce397d21

drivers/dma/mv_xor_v2.c

+4 −0
Original line number Diff line number Diff line
@@ -174,6 +174,7 @@ struct mv_xor_v2_device { 
	int desc_size;

	unsigned int npendings;

	unsigned int hw_queue_idx;

	struct msi_desc *msi_desc;

};



/**
@@ -780,6 +781,7 @@ static int mv_xor_v2_probe(struct platform_device *pdev) 
	msi_desc = first_msi_entry(&pdev->dev);

	if (!msi_desc)

		goto free_msi_irqs;

	xor_dev->msi_desc = msi_desc;



	ret = devm_request_irq(&pdev->dev, msi_desc->irq,

			       mv_xor_v2_interrupt_handler, 0,
@@ -897,6 +899,8 @@ static int mv_xor_v2_remove(struct platform_device *pdev) 
			  xor_dev->desc_size * MV_XOR_V2_DESC_NUM,

			  xor_dev->hw_desq_virt, xor_dev->hw_desq);



	devm_free_irq(&pdev->dev, xor_dev->msi_desc->irq, xor_dev);



	platform_msi_domain_free_irqs(&pdev->dev);



	clk_disable_unprepare(xor_dev->clk);