qcacld-3.0: Remove validate_context check from wlan_resume
Presently, there is a very narrow race condition that causes scheduler_thread to remain in a suspended state for undefined period of time. The race condition occuers between idle_psoc_timeout and wlan_hdd_cfg80211_resume_wlan. As a part of idle_psoc_timeout, the driver calls hdd_wlan_stop_modules that sets the flag "stop_module_in_progress" and checks if driver is in suspended state. If yes, it resets the flag and returns. But in the case of a race condition, before this reset and return is carried out, wlan_hdd_cfg80211_resume_wlan is invoked. The validate_context inside the resume function fails due to the above mentioned flag being set. As a result, resume fails and the driver stays in suspended state. This causes the driver to enter a infinite loop of stop_modules not being successful. To close this small window of contention, remove the validate_context check. hdd_ctx is always guranteed to be valid and also DSC takes care of synchronizing the operation, thus the check is redundant. Change-Id: I723f78e4c33bdc531776c46eff2428dbd869493f CRs-Fixed: 2616177
Loading
Please register or sign in to comment