Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 587e45de authored by Wei Yongjun's avatar Wei Yongjun Committed by Blagovest Kolenichev
Browse files

usb: gadget: configfs: Fix missing spin_lock_init() 



commit 093edc2baad2c258b1f55d1ab9c63c2b5ae67e42 upstream.

The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

This is detected by Coccinelle semantic patch.

Change-Id: Ibac3a73de582ea97c54d97d9d6104ee027cb446f
Fixes: 1a1c851bbd70 ("usb: gadget: configfs: fix concurrent issue between composite APIs")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Cc: stable <stable@vger.kernel.org>
Reviewed-by: default avatarPeter Chen <peter.chen@nxp.com>
Link: https://lore.kernel.org/r/20191030034046.188808-1-weiyongjun1@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Git-commit: f777dd5b
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git


Signed-off-by: default avatarBlagovest Kolenichev <bkolenichev@codeaurora.org>
parent b7f52671

drivers/usb/gadget/configfs.c

+1 −0
Original line number Diff line number Diff line
@@ -1788,6 +1788,7 @@ static struct config_group *gadgets_make( 
	gi->composite.resume = NULL;

	gi->composite.max_speed = USB_SPEED_SUPER;



	spin_lock_init(&gi->spinlock);

	mutex_init(&gi->lock);

	INIT_LIST_HEAD(&gi->string_list);

	INIT_LIST_HEAD(&gi->available_func);