Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a490122 authored by Guido Martínez's avatar Guido Martínez Committed by Dave Airlie
Browse files

drm/tilcdc: panel: fix leak when unloading the module 



The driver did not unregister the allocated framebuffer, which caused
memory leaks (and memory manager WARNs) when unloading. Also, the
framebuffer device under /dev still existed after unloading.

Add a call to drm_fbdev_cma_fini when unloading the module to prevent
both issues.

Signed-off-by: default avatarGuido Martínez <guido@vanguardiasur.com.ar>
Tested-by: default avatarDarren Etheridge <detheridge@ti.com>
Cc: <stable@vger.kernel.org> #v3.9+
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 16dcbdef

drivers/gpu/drm/tilcdc/tilcdc_drv.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -122,6 +122,7 @@ static int tilcdc_unload(struct drm_device *dev) 
	struct tilcdc_drm_private *priv = dev->dev_private;

	struct tilcdc_drm_private *priv = dev->dev_private;

	struct tilcdc_module *mod, *cur;

	struct tilcdc_module *mod, *cur;





	drm_fbdev_cma_fini(priv->fbdev);

	drm_kms_helper_poll_fini(dev);

	drm_kms_helper_poll_fini(dev);

	drm_mode_config_cleanup(dev);

	drm_mode_config_cleanup(dev);

	drm_vblank_cleanup(dev);

	drm_vblank_cleanup(dev);