UPSTREAM: coresight: tmc-etr: Refactor for handling errors

Refactor the tmc-etr enable operation to make it easier to
handle errors in enabling the hardware. We need to make
sure that the buffer is compatible with the ETR. This
patch re-arranges to make the error handling easier, by
deferring the hardware enablement until all the errors
are checked. This also avoids turning the CATU on/off
during a sysfs read session.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

(Upstream commit 6276f9cba50f77c5b51b581c11b74a51a3f9e040).

Bug: 140266694
Change-Id: Ib7f1d20fd5b999f27c2a609de68600e1de8ab317
Signed-off-by: Yabin Cui <yabinc@google.com>