Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fceb5bc7 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nicholas Bellinger
Browse files

iscsit: mark various functions static 



This patch marks a number of functions static to appease sparse static
checking.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent d7ca663c

drivers/target/iscsi/iscsi_target.c

+1 −1
Original line number Diff line number Diff line
@@ -427,7 +427,7 @@ int iscsit_reset_np_thread( 
	return 0;

}



int iscsit_del_np_comm(struct iscsi_np *np)

static int iscsit_del_np_comm(struct iscsi_np *np)

{

	if (np->np_socket)

		sock_release(np->np_socket);

drivers/target/iscsi/iscsi_target.h

+5 −0
Original line number Diff line number Diff line
@@ -38,4 +38,9 @@ extern struct kmem_cache *lio_cmd_cache; 
extern struct kmem_cache *lio_qr_cache;

extern struct kmem_cache *lio_r2t_cache;



extern struct idr sess_idr;

extern struct mutex auth_id_lock;

extern spinlock_t sess_idr_lock;





#endif   /*** ISCSI_TARGET_H ***/

drivers/target/iscsi/iscsi_target_configfs.c

+5 −5
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ static struct configfs_attribute *lio_target_portal_attrs[] = { 


#define MAX_PORTAL_LEN		256



struct se_tpg_np *lio_target_call_addnptotpg(

static struct se_tpg_np *lio_target_call_addnptotpg(

	struct se_portal_group *se_tpg,

	struct config_group *group,

	const char *name)
@@ -1170,7 +1170,7 @@ static struct configfs_attribute *lio_target_tpg_attrs[] = { 


/* Start items for lio_target_tiqn_cit */



struct se_portal_group *lio_target_tiqn_addtpg(

static struct se_portal_group *lio_target_tiqn_addtpg(

	struct se_wwn *wwn,

	struct config_group *group,

	const char *name)
@@ -1220,7 +1220,7 @@ out: 
	return NULL;

}



void lio_target_tiqn_deltpg(struct se_portal_group *se_tpg)

static void lio_target_tiqn_deltpg(struct se_portal_group *se_tpg)

{

	struct iscsi_portal_group *tpg;

	struct iscsi_tiqn *tiqn;
@@ -1252,7 +1252,7 @@ static struct configfs_attribute *lio_target_wwn_attrs[] = { 
	NULL,

};



struct se_wwn *lio_target_call_coreaddtiqn(

static struct se_wwn *lio_target_call_coreaddtiqn(

	struct target_fabric_configfs *tf,

	struct config_group *group,

	const char *name)
@@ -1300,7 +1300,7 @@ struct se_wwn *lio_target_call_coreaddtiqn( 
	return &tiqn->tiqn_wwn;

}



void lio_target_call_coredeltiqn(

static void lio_target_call_coredeltiqn(

	struct se_wwn *wwn)

{

	struct iscsi_tiqn *tiqn = container_of(wwn, struct iscsi_tiqn, tiqn_wwn);

drivers/target/iscsi/iscsi_target_erl0.c

+4 −4
Original line number Diff line number Diff line
@@ -685,7 +685,7 @@ recover: 
 *	Called from iscsit_handle_data_out() before DataOUT Payload is received

 *	and CRC computed.

 */

extern int iscsit_check_pre_dataout(

int iscsit_check_pre_dataout(

	struct iscsi_cmd *cmd,

	unsigned char *buf)

{
@@ -789,7 +789,7 @@ static void iscsit_handle_time2retain_timeout(unsigned long data) 
	target_put_session(sess->se_sess);

}



extern void iscsit_start_time2retain_handler(struct iscsi_session *sess)

void iscsit_start_time2retain_handler(struct iscsi_session *sess)

{

	int tpg_active;

	/*
@@ -822,7 +822,7 @@ extern void iscsit_start_time2retain_handler(struct iscsi_session *sess) 
/*

 *	Called with spin_lock_bh(&struct se_portal_group->session_lock) held

 */

extern int iscsit_stop_time2retain_timer(struct iscsi_session *sess)

int iscsit_stop_time2retain_timer(struct iscsi_session *sess)

{

	struct iscsi_portal_group *tpg = ISCSI_TPG_S(sess);

	struct se_portal_group *se_tpg = &tpg->tpg_se_tpg;
@@ -926,7 +926,7 @@ static void iscsit_handle_connection_cleanup(struct iscsi_conn *conn) 
	}

}



extern void iscsit_take_action_for_connection_exit(struct iscsi_conn *conn)

void iscsit_take_action_for_connection_exit(struct iscsi_conn *conn)

{

	spin_lock_bh(&conn->state_lock);

	if (atomic_read(&conn->connection_exit)) {

drivers/target/iscsi/iscsi_target_erl2.c

+1 −3
Original line number Diff line number Diff line
@@ -193,15 +193,13 @@ int iscsit_remove_active_connection_recovery_entry( 
	return 0;

}



int iscsit_remove_inactive_connection_recovery_entry(

static void iscsit_remove_inactive_connection_recovery_entry(

	struct iscsi_conn_recovery *cr,

	struct iscsi_session *sess)

{

	spin_lock(&sess->cr_i_lock);

	list_del(&cr->cr_list);

	spin_unlock(&sess->cr_i_lock);



	return 0;

}



/*