Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7ca663c authored by Dan Carpenter's avatar Dan Carpenter Committed by Nicholas Bellinger
Browse files

target/iscsi: precedence bug in iscsit_set_dataout_sequence_values() 



Clang warns about this bug:
drivers/target/iscsi/iscsi_target_erl0.c:52:45: warning: operator '?:'
	has lower precedence than '+'; '+' will be evaluated first
	[-Wparentheses]

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 232ebe34

drivers/target/iscsi/iscsi_target_erl0.c

+3 −3
Original line number Diff line number Diff line
@@ -48,9 +48,9 @@ void iscsit_set_dataout_sequence_values( 
	if (cmd->unsolicited_data) {

		cmd->seq_start_offset = cmd->write_data_done;

		cmd->seq_end_offset = (cmd->write_data_done +

			(cmd->se_cmd.data_length >

			((cmd->se_cmd.data_length >

			  conn->sess->sess_ops->FirstBurstLength) ?

			conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length);

			 conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length));

		return;

	}