packet: fix race condition in packet_set_ring
When packet_set_ring creates a ring buffer it will initialize a struct timer_list if the packet version is TPACKET_V3. This value can then be raced by a different thread calling setsockopt to set the version to TPACKET_V1 before packet_set_ring has finished. This leads to a use-after-free on a function pointer in the struct timer_list when the socket is closed as the previously initialized timer will not be deleted. The bug is fixed by taking lock_sock(sk) in packet_setsockopt when changing the packet version while also taking the lock at the start of packet_set_ring. Fixes: f6fb8f10 ("af-packet: TPACKET_V3 flexible buffer implementation.") Signed-off-by:Philip Pettersson <philip.pettersson@gmail.com> Signed-off-by:
Eric Dumazet <edumazet@google.com> Signed-off-by:
David S. Miller <davem@davemloft.net> Change-Id: Ia910f64aff0ce7487ac05a7caae5c406e06ec9fd Git-repo: git://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git Git-commit: 84ac7260236a49c79eede91617700174c2c19b0c Signed-off-by:
Dennis Cagle <d-cagle@codeaurora.org>
Loading
Please register or sign in to comment