Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea0dbebf authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: opticon: fix DMA from stack 



Make sure to allocate the control-message buffer dynamically as some
platforms cannot do DMA from stack.

Note that only the first byte of the old buffer was used.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2f0295ad

drivers/usb/serial/opticon.c

+6 −1
Original line number Diff line number Diff line
@@ -155,7 +155,11 @@ static int send_control_msg(struct usb_serial_port *port, u8 requesttype, 
{

	struct usb_serial *serial = port->serial;

	int retval;

	u8 buffer[2];

	u8 *buffer;



	buffer = kzalloc(1, GFP_KERNEL);

	if (!buffer)

		return -ENOMEM;



	buffer[0] = val;

	/* Send the message to the vendor control endpoint
@@ -164,6 +168,7 @@ static int send_control_msg(struct usb_serial_port *port, u8 requesttype, 
				requesttype,

				USB_DIR_OUT|USB_TYPE_VENDOR|USB_RECIP_INTERFACE,

				0, 0, buffer, 1, 0);

	kfree(buffer);



	return retval;

}