Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f0295ad authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: quatech2: fix io after disconnect 



Make sure no control urb is submitted during close after a disconnect by
checking the disconnected flag.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8e512ab0

drivers/usb/serial/quatech2.c

+7 −0
Original line number Diff line number Diff line
@@ -427,6 +427,12 @@ static void qt2_close(struct usb_serial_port *port) 
	port_priv->urb_in_use = false;

	spin_unlock_irqrestore(&port_priv->urb_lock, flags);



	mutex_lock(&port->serial->disc_mutex);

	if (port->serial->disconnected) {

		mutex_unlock(&port->serial->disc_mutex);

		return;

	}



	/* flush the port transmit buffer */

	i = usb_control_msg(serial->dev,

			    usb_rcvctrlpipe(serial->dev, 0),
@@ -458,6 +464,7 @@ static void qt2_close(struct usb_serial_port *port) 
		dev_err(&port->dev, "%s - close port failed %i\n",

			__func__, i);



	mutex_unlock(&port->serial->disc_mutex);

}



static void qt2_disconnect(struct usb_serial *serial)