Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e512ab0 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: quatech2: fix close and disconnect urb handling 



Kill urbs unconditionally at close and disconnect.

Note that URB status is not valid outside of completion handler.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40d04738

drivers/usb/serial/quatech2.c

+2 −4
Original line number Diff line number Diff line
@@ -423,7 +423,6 @@ static void qt2_close(struct usb_serial_port *port) 
	port_priv->is_open = false;



	spin_lock_irqsave(&port_priv->urb_lock, flags);

	if (port_priv->write_urb->status == -EINPROGRESS)

	usb_kill_urb(port_priv->write_urb);

	port_priv->urb_in_use = false;

	spin_unlock_irqrestore(&port_priv->urb_lock, flags);
@@ -465,7 +464,6 @@ static void qt2_disconnect(struct usb_serial *serial) 
{

	struct qt2_serial_private *serial_priv = usb_get_serial_data(serial);



	if (serial_priv->read_urb->status == -EINPROGRESS)

	usb_kill_urb(serial_priv->read_urb);

}