Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0172fd3 authored by Maxim Levitsky's avatar Maxim Levitsky Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: IR: fix keys beeing stuck down forever 



The logic in ir_timer_keyup was inverted.

In case that values aren't equal,
the meaning of the time_is_after_eq_jiffies(ir->keyup_jiffies) is that
ir->keyup_jiffies is after the the jiffies or equally that
that jiffies are before the the ir->keyup_jiffies which is
exactly the situation we want to avoid (that the timeout is in the future)
Confusing Eh?

Signed-off-by: default avatarMaxim Levitsky <maximlevitsky@gmail.com>
Acked-by: default avatarJarod Wilson <jarod@redhat.com>
Cc: stable@kernel.org
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 67332ba8

drivers/media/IR/ir-keytable.c

+1 −1
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ static void ir_timer_keyup(unsigned long cookie) 
	 * a keyup event might follow immediately after the keydown.

	 */

	spin_lock_irqsave(&ir->keylock, flags);

	if (time_is_after_eq_jiffies(ir->keyup_jiffies))

	if (time_is_before_eq_jiffies(ir->keyup_jiffies))

		ir_keyup(ir);

	spin_unlock_irqrestore(&ir->keylock, flags);

}