Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3946fda authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Amit Pundir
Browse files

trace: fix trace_graph_ret_raw return type

As found by kernelci, an extraneous semicolon causes incorrect
behavior in one of the tracing functions:

kernel/trace/trace_output.c: In function 'trace_graph_ret_raw':
kernel/trace/trace_output.c:976:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  if (!trace_seq_printf(&iter->seq, "%lx %lld %lld %ld %d\n",
  ^~
kernel/trace/trace_output.c:982:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   return TRACE_TYPE_PARTIAL_LINE;

This removes the semicolon to make the function return success
correctly.

Link: https://kernelci.org/build/id/5910641d59b514cb17b12d4d/logs/


Fixes: 6f6f99a3 ("trace: add non-hierarchical function_graph option")
Cc: Jamie Gennis <jgennis@google.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 72480c28
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment