Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc4f07c8 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192ee: Pass large struct by const reference 



struct rtl_stats is rather huge (152 bytes), and since
rtl92ee_rx_command_packet() does not modify it, it might as
well be passed by const reference.

Reported by Coverity: CID 1222131

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 57fc3b7c

drivers/staging/rtl8192ee/pci.c

+1 −1
Original line number Diff line number Diff line
@@ -892,7 +892,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) 
		}



		/* handle command packet here */

		if (rtlpriv->cfg->ops->rx_command_packet(hw, stats, skb)) {

		if (rtlpriv->cfg->ops->rx_command_packet(hw, &stats, skb)) {

				dev_kfree_skb_any(skb);

				goto end;

		}

drivers/staging/rtl8192ee/rtl8192ee/trx.c

+2 −2
Original line number Diff line number Diff line
@@ -1263,13 +1263,13 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) 
}



u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,

			      struct rtl_stats status,

			      const struct rtl_stats *status,

			      struct sk_buff *skb)

{

	u32 result = 0;

	struct rtl_priv *rtlpriv = rtl_priv(hw);



	switch (status.packet_report_type) {

	switch (status->packet_report_type) {

	case NORMAL_RX:

		result = 0;

		break;

drivers/staging/rtl8192ee/rtl8192ee/trx.h

+1 −1
Original line number Diff line number Diff line
@@ -872,6 +872,6 @@ void rtl92ee_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc, 
			     bool b_firstseg, bool b_lastseg,

			     struct sk_buff *skb);

u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,

			      struct rtl_stats status,

			      const struct rtl_stats *status,

			      struct sk_buff *skb);

#endif

drivers/staging/rtl8192ee/wifi.h

+1 −1
Original line number Diff line number Diff line
@@ -1946,7 +1946,7 @@ struct rtl_hal_ops { 
			     u32 cmd_len, u8 *p_cmdbuffer);

	bool (*get_btc_status)(void);

	u32 (*rx_command_packet)(struct ieee80211_hw *hw,

				 struct rtl_stats status, struct sk_buff *skb);

				 const struct rtl_stats *status, struct sk_buff *skb);

	void (*add_wowlan_pattern)(struct ieee80211_hw *hw,

				   struct rtl_wow_pattern *rtl_pattern,

				   u8 index);