Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57fc3b7c authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Greg Kroah-Hartman
Browse files

staging: rtl8821ae: Pass large struct by const reference 



struct rtl_stats is rather huge (152 bytes), and since
rtl8812ae_rx_command_packet_handler() does not modify it, it might as
well be passed by const reference.

Reported by Coverity: CID 1167285

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a71d10df

drivers/staging/rtl8821ae/pci.c

+1 −1
Original line number Diff line number Diff line
@@ -861,7 +861,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) 
			break;

		}



		rtlpriv->cfg->ops->rx_command_packet_handler(hw, status, skb);

		rtlpriv->cfg->ops->rx_command_packet_handler(hw, &status, skb);



		/*

		 *NOTICE This can not be use for mac80211,

drivers/staging/rtl8821ae/rtl8821ae/sw.c

+2 −2
Original line number Diff line number Diff line
@@ -227,14 +227,14 @@ void rtl8821ae_deinit_sw_vars(struct ieee80211_hw *hw) 


static u32 rtl8812ae_rx_command_packet_handler(

	struct ieee80211_hw *hw,

	struct rtl_stats status,

	const struct rtl_stats *status,

	struct sk_buff *skb

	)

{

	u32 result = 0;

	struct rtl_priv *rtlpriv = rtl_priv(hw);



	switch (status.packet_report_type) {

	switch (status->packet_report_type) {

		case NORMAL_RX:

			result = 0;

			break;

drivers/staging/rtl8821ae/wifi.h

+1 −1
Original line number Diff line number Diff line
@@ -1853,7 +1853,7 @@ struct rtl_hal_ops { 
			     u32 cmd_len, u8 *p_cmdbuffer);

	bool (*get_btc_status)(void);

	u32 (*rx_command_packet_handler)(struct ieee80211_hw *hw,

					 struct rtl_stats status,

					 const struct rtl_stats *status,

					 struct sk_buff *skb);

};