Commit b87c0adf authored Oct 19, 2006 by Chuck Lever Committed by Linus Torvalds Oct 20, 2006

[PATCH] NFS: remove unused check in nfs4_open_revalidate



Coverity spotted a superfluous error check in nfs4_open_revalidate().  Remove
it.

Coverity: #cid 847

Test plan:
Code inspection; another pass through Coverity.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 85233a7a

fs/nfs/nfs4proc.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1314,12 +1314,10 @@ nfs4_open_revalidate(struct inode dir, struct dentry dentry, int openflags, st
		case -EROFS:
		lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
		return 1;
		case -ENOENT:
		if (dentry->d_inode == NULL)
		return 1;
		}
		default:
		goto out_drop;
		}
		}
		if (state->inode == dentry->d_inode) {
		nfs4_intent_set_file(nd, dentry, state);
		return 1;