Commit 85233a7a authored Oct 19, 2006 by Chuck Lever Committed by Linus Torvalds Oct 20, 2006

[PATCH] NFS: __nfs_revalidate_inode() can use "inode" before checking it is non-NULL



The "!inode" check in __nfs_revalidate_inode() occurs well after the first
time it is dereferenced, so get rid of it.

Coverity: #cid 1372, 1373

Test plan:
Code review; recheck with Coverity.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 39cf8a13

fs/nfs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -583,7 +583,7 @@ __nfs_revalidate_inode(struct nfs_server server, struct inode inode)

		nfs_inc_stats(inode, NFSIOS_INODEREVALIDATE);
		lock_kernel();
		if (!inode \|\| is_bad_inode(inode))
		if (is_bad_inode(inode))
		goto out_nowait;
		if (NFS_STALE(inode))
		goto out_nowait;