Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39cf8a13 authored by Chuck Lever's avatar Chuck Lever Committed by Linus Torvalds
Browse files

[PATCH] NFS: fix minor bug in new NFS symlink code 



The original code confused a zero return code from pagevec_add() as success.

Test plan:
None.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent cd9ae2b6

fs/nfs/dir.c

+2 −2
Original line number Diff line number Diff line
@@ -1519,8 +1519,8 @@ static int nfs_symlink(struct inode *dir, struct dentry *dentry, const char *sym 
	pagevec_init(&lru_pvec, 0);

	if (!add_to_page_cache(page, dentry->d_inode->i_mapping, 0,

							GFP_KERNEL)) {

		if (!pagevec_add(&lru_pvec, page))

			__pagevec_lru_add(&lru_pvec);

		pagevec_add(&lru_pvec, page);

		pagevec_lru_add(&lru_pvec);

		SetPageUptodate(page);

		unlock_page(page);

	} else