Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acbf0e52 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: opticon: fix memory leak in error path 



Fix memory leak in write error path.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ea0dbebf

drivers/usb/serial/opticon.c

+3 −1
Original line number Diff line number Diff line
@@ -286,7 +286,7 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port, 
	if (!dr) {

		dev_err(&port->dev, "out of memory\n");

		count = -ENOMEM;

		goto error;

		goto error_no_dr;

	}



	dr->bRequestType = USB_TYPE_VENDOR | USB_RECIP_INTERFACE | USB_DIR_OUT;
@@ -316,6 +316,8 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port, 


	return count;

error:

	kfree(dr);

error_no_dr:

	usb_free_urb(urb);

error_no_urb:

	kfree(buffer);