Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a36689cb authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm/i915: Be more informative when reporting "too large for aperture" error 

This should help debugging the truly unexpected cases where it occurs -
in particular to see which value is garbage.

References: https://bugzilla.kernel.org/show_bug.cgi?id=58511


Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
[danvet: s/%ld/%zd/ as spotted by Wu Fengguang's autobuilder.]
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 90a88643

drivers/gpu/drm/i915/i915_gem.c

+4 −1
Original line number Diff line number Diff line
@@ -2975,7 +2975,10 @@ i915_gem_object_bind_to_gtt(struct drm_i915_gem_object *obj, 
	 */

	if (obj->base.size >

	    (map_and_fenceable ? dev_priv->gtt.mappable_end : dev_priv->gtt.total)) {

		DRM_ERROR("Attempting to bind an object larger than the aperture\n");

		DRM_ERROR("Attempting to bind an object larger than the aperture: object=%zd > %s aperture=%ld\n",

			  obj->base.size,

			  map_and_fenceable ? "mappable" : "total",

			  map_and_fenceable ? dev_priv->gtt.mappable_end : dev_priv->gtt.total);

		return -E2BIG;

	}