Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 909d9cda authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Dave Airlie
Browse files

drm: Don't allow page flip to change pixel format 



A page flip is not a mode set, changing the frame buffer pixel format
doesn't make sense and isn't handled by most drivers anyway. Disallow
it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 64c026e2

drivers/gpu/drm/drm_crtc.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -3638,6 +3638,12 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, 
		goto out;

		goto out;

	}

	}





	if (crtc->fb->pixel_format != fb->pixel_format) {

		DRM_DEBUG_KMS("Page flip is not allowed to change frame buffer format.\n");

		ret = -EINVAL;

		goto out;

	}



	if (page_flip->flags & DRM_MODE_PAGE_FLIP_EVENT) {

	if (page_flip->flags & DRM_MODE_PAGE_FLIP_EVENT) {

		ret = -ENOMEM;

		ret = -ENOMEM;

		spin_lock_irqsave(&dev->event_lock, flags);

		spin_lock_irqsave(&dev->event_lock, flags);