Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 904753da authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nicholas Bellinger
Browse files

iscsit: remove incorrect unlock in iscsit_build_sendtargets_resp 



Fix a potential multiple spin-unlock -> deadlock scenario during the
overflow check within iscsit_build_sendtargets_resp() as found by
sparse static checking.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent fceb5bc7

drivers/target/iscsi/iscsi_target.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -3274,7 +3274,6 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd) 
		len += 1;

		len += 1;





		if ((len + payload_len) > buffer_len) {

		if ((len + payload_len) > buffer_len) {

			spin_unlock(&tiqn->tiqn_tpg_lock);

			end_of_buf = 1;

			end_of_buf = 1;

			goto eob;

			goto eob;

		}

		}