Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88ca518b authored by Takashi Iwai's avatar Takashi Iwai Committed by Matthew Garrett
Browse files

intel_ips: blacklist HP ProBook laptops 



intel_ips driver spews the warning message
  "ME failed to update for more than 1s, likely hung"
at each second endlessly on HP ProBook laptops with IronLake.

As this has never worked, better to blacklist the driver for now.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent 57f9616b

drivers/platform/x86/intel_ips.c

+22 −0
Original line number Diff line number Diff line
@@ -72,6 +72,7 @@ 
#include <linux/string.h>

#include <linux/tick.h>

#include <linux/timer.h>

#include <linux/dmi.h>

#include <drm/i915_drm.h>

#include <asm/msr.h>

#include <asm/processor.h>
@@ -1485,6 +1486,24 @@ static DEFINE_PCI_DEVICE_TABLE(ips_id_table) = { 


MODULE_DEVICE_TABLE(pci, ips_id_table);



static int ips_blacklist_callback(const struct dmi_system_id *id)

{

	pr_info("Blacklisted intel_ips for %s\n", id->ident);

	return 1;

}



static const struct dmi_system_id ips_blacklist[] = {

	{

		.callback = ips_blacklist_callback,

		.ident = "HP ProBook",

		.matches = {

			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),

			DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook"),

		},

	},

	{ }	/* terminating entry */

};



static int ips_probe(struct pci_dev *dev, const struct pci_device_id *id)

{

	u64 platform_info;
@@ -1494,6 +1513,9 @@ static int ips_probe(struct pci_dev *dev, const struct pci_device_id *id) 
	u16 htshi, trc, trc_required_mask;

	u8 tse;



	if (dmi_check_system(ips_blacklist))

		return -ENODEV;



	ips = kzalloc(sizeof(struct ips_driver), GFP_KERNEL);

	if (!ips)

		return -ENOMEM;