Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57f9616b authored by Dan Carpenter's avatar Dan Carpenter Committed by Matthew Garrett
Browse files

ideapad: uninitialized data in ideapad_acpi_add() 



We only initialize the high bits of "cfg".  It probably doesn't cause
a problem given that this is platform specific code and doesn't have to
worry about endianness etc.  But it's sort of messy.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent a1071a5a

drivers/platform/x86/ideapad-laptop.c

+3 −3
Original line number Diff line number Diff line
@@ -694,10 +694,10 @@ MODULE_DEVICE_TABLE(acpi, ideapad_device_ids); 
static int __devinit ideapad_acpi_add(struct acpi_device *adevice)

{

	int ret, i;

	unsigned long cfg;

	int cfg;

	struct ideapad_private *priv;



	if (read_method_int(adevice->handle, "_CFG", (int *)&cfg))

	if (read_method_int(adevice->handle, "_CFG", &cfg))

		return -ENODEV;



	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
@@ -721,7 +721,7 @@ static int __devinit ideapad_acpi_add(struct acpi_device *adevice) 
		goto input_failed;



	for (i = 0; i < IDEAPAD_RFKILL_DEV_NUM; i++) {

		if (test_bit(ideapad_rfk_data[i].cfgbit, &cfg))

		if (test_bit(ideapad_rfk_data[i].cfgbit, &priv->cfg))

			ideapad_register_rfkill(adevice, i);

		else

			priv->rfk[i] = NULL;