Commit 87bfbf67 authored Jun 26, 2006 by Eric W. Biederman Committed by Linus Torvalds Jun 26, 2006

[PATCH] proc: Simplify the ownership rules for /proc



Currently in /proc if the task is dumpable all of files are owned by the tasks
effective users.  Otherwise the files are owned by root.  Unless it is the
/proc/<tgid>/ or /proc/<tgid>/task/<pid> directory in that case we always make
the directory owned by the effective user.

However the special case for directories is pointless except as a way to read
the effective user, because the permissions on both of those directories are
world readable, and executable.

/proc/<tgid>/status provides a much better way to read a processes effecitve
userid, so it is silly to try to provide that on the directory.

So this patch simplifies the code by removing a pointless special case and
gets us one step closer to being able to remove the hard coded /proc inode
numbers.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 16796549

fs/proc/base.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1371,7 +1371,7 @@ static struct inode proc_pid_make_inode(struct super_block sb, struct task_st
		ei->type = ino;
		inode->i_uid = 0;
		inode->i_gid = 0;
		if (ino == PROC_TGID_INO \|\| ino == PROC_TID_INO \|\| task_dumpable(task)) {
		if (task_dumpable(task)) {
		inode->i_uid = task->euid;
		inode->i_gid = task->egid;
		}
		@@ -1400,7 +1400,7 @@ static int pid_revalidate(struct dentry dentry, struct nameidata nd)
		struct inode *inode = dentry->d_inode;
		struct task_struct *task = proc_task(inode);
		if (pid_alive(task)) {
		if (proc_type(inode) == PROC_TGID_INO \|\| proc_type(inode) == PROC_TID_INO \|\| task_dumpable(task)) {
		if (task_dumpable(task)) {
		inode->i_uid = task->euid;
		inode->i_gid = task->egid;
		} else {