Commit 16796549 authored Jun 26, 2006 by Eric W. Biederman Committed by Linus Torvalds Jun 26, 2006

[PATCH] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode



The removed fields are already set by proc_alloc_inode.  Initializing them in
proc_alloc_inode implies they need it for proper cleanup.  At least ei->pde
was not set on all paths making it look like proc_alloc_inode was buggy.  So
just remove the redundant assignments.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent ff9724a3

fs/proc/base.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1357,7 +1357,6 @@ static struct inode proc_pid_make_inode(struct super_block sb, struct task_st

		/* Common stuff */
		ei = PROC_I(inode);
		ei->task = NULL;
		inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
		inode->i_ino = fake_ino(task->pid, ino);

		@@ -1382,7 +1381,6 @@ out:
		return inode;

		out_unlock:
		ei->pde = NULL;
		iput(inode);
		return NULL;
		}