Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85f96af9 authored by Linus Torvalds's avatar Linus Torvalds Committed by Gerrit - the friendly Code Review server
Browse files

mm: get rid of vmacache_flush_all() entirely



Jann Horn points out that the vmacache_flush_all() function is not only
potentially expensive, it's buggy too.  It also happens to be entirely
unnecessary, because the sequence number overflow case can be avoided by
simply making the sequence number be 64-bit.  That doesn't even grow the
data structures in question, because the other adjacent fields are
already 64-bit.

So simplify the whole thing by just making the sequence number overflow
case go away entirely, which gets rid of all the complications and makes
the code faster too.  Win-win.

[ Oleg Nesterov points out that the VMACACHE_FULL_FLUSHES statistics
  also just goes away entirely with this ].

Change-Id: Ic9ffd061f3116cfcf563a5d9808c3dddf0547e5d
Reported-by: default avatarJann Horn <jannh@google.com>
Suggested-by: default avatarWill Deacon <will.deacon@arm.com>
Acked-by: default avatarDavidlohr Bueso <dave@stgolabs.net>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Git-commit: 7a9cdebdcc17e426fb5287e4a82db1dfe86339b2
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarKrishnamurthy K R <kkr@codeaurora.org>
parent aa3cd2ff
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment