Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 848110b8 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Sasha Levin
Browse files

rtc: max77686: Properly handle regmap_irq_get_virq() error code



[ Upstream commit fb166ba1d7f0a662f7332f4ff660a0d6f4d76915 ]

The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
but driver checked only for value of 0.

This could lead to a cast of -EINVAL to an unsigned int used as a
interrupt number for devm_request_threaded_irq(). Although this is not
yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
might be a misleading when diagnosing errors.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 6f1c1e71 ("mfd: max77686: Convert to use regmap_irq")
Reviewed-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent 942827fc
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment