Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 808e34e2 authored by Zoltan Kiss's avatar Zoltan Kiss Committed by Bjorn Helgaas
Browse files

PCI: Disable decoding for BAR sizing only when it was actually enabled 



We disable BARs while sizing them so we don't cause conflicts with other
devices (see 253d2e54 and bbffe435).  But if device decoding is already
disabled before we size the BAR, we don't need to disable it again.

[bhelgaas: changelog, add PCI_COMMAND_DECODING_ENABLE for readability]
Signed-off-by: default avatarZoltan Kiss <zoltan.kiss@citrix.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent da27f4b3

drivers/pci/probe.c

+8 −3
Original line number Diff line number Diff line
@@ -156,6 +156,8 @@ static inline unsigned long decode_bar(struct pci_dev *dev, u32 bar) 
	return flags;

}



#define PCI_COMMAND_DECODE_ENABLE	(PCI_COMMAND_MEMORY | PCI_COMMAND_IO)



/**

 * pci_read_base - read a PCI BAR

 * @dev: the PCI device
@@ -178,8 +180,10 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, 
	/* No printks while decoding is disabled! */

	if (!dev->mmio_always_on) {

		pci_read_config_word(dev, PCI_COMMAND, &orig_cmd);

		if (orig_cmd & PCI_COMMAND_DECODE_ENABLE) {

			pci_write_config_word(dev, PCI_COMMAND,

			orig_cmd & ~(PCI_COMMAND_MEMORY | PCI_COMMAND_IO));

				orig_cmd & ~PCI_COMMAND_DECODE_ENABLE);

		}

	}



	res->name = pci_name(dev);
@@ -293,7 +297,8 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, 
fail:

	res->flags = 0;

out:

	if (!dev->mmio_always_on)

	if (!dev->mmio_always_on &&

	    (orig_cmd & PCI_COMMAND_DECODE_ENABLE))

		pci_write_config_word(dev, PCI_COMMAND, orig_cmd);



	if (bar_too_big)