Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 796a8e42 authored by Ben Dooks's avatar Ben Dooks Committed by Linus Torvalds
Browse files

gpiolib: make gpiochip_add() show a better error message 



The current message, 'not registered' is confusing as it implies it was
not registered with something, whereas printing 'failed to register'
implies it was the gpiochip_add() call that did not work correctly.

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a13c1868

drivers/gpio/gpiolib.c

+1 −1
Original line number Diff line number Diff line
@@ -1106,7 +1106,7 @@ unlock: 
fail:

	/* failures here can mean systems won't boot... */

	if (status)

		pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n",

		pr_err("gpiochip_add: gpios %d..%d (%s) failed to register\n",

			chip->base, chip->base + chip->ngpio - 1,

			chip->label ? : "generic");

	return status;