Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a13c1868 authored by Marc Zyngier's avatar Marc Zyngier Committed by Linus Torvalds
Browse files

gpio: max732x: fix input configuration for open-drain pins 



Fix a bug I noticed while hacking on the max732x driver for interrupt
support.  According to the datasheets, open-drain pins have to be
configured as output-high (which in that case is actually high impedance)
to be used as input.

Signed-off-by: default avatarMarc Zyngier <maz@misterjones.org>
Acked-by: default avatarEric Miao <eric.y.miao@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5535cb68

drivers/gpio/max732x.c

+7 −0
Original line number Diff line number Diff line
@@ -232,6 +232,13 @@ static int max732x_gpio_direction_input(struct gpio_chip *gc, unsigned off) 
		return -EACCES;

	}



	/*

	 * Open-drain pins must be set to high impedance (which is

	 * equivalent to output-high) to be turned into an input.

	 */

	if ((mask & chip->dir_output))

		max732x_gpio_set_value(gc, off, 1);



	return 0;

}