Commit 73f7545a authored Dec 26, 2016 by Thomas Gleixner Committed by Greg Kroah-Hartman Aug 11, 2017

x86/mce/AMD: Make the init code more robust




[ Upstream commit 0dad3a3014a0b9e72521ff44f17e0054f43dcdea ]

If mce_device_init() fails then the mce device pointer is NULL and the
AMD mce code happily dereferences it.

Add a sanity check.

Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e7ef4f1f

arch/x86/kernel/cpu/mcheck/mce_amd.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -573,6 +573,9 @@ static int threshold_create_bank(unsigned int cpu, unsigned int bank)
		const char *name = th_names[bank];
		int err = 0;

		if (!dev)
		return -ENODEV;

		if (is_shared_bank(bank)) {
		nb = node_to_amd_nb(amd_get_nb_id(cpu));