Commit e7ef4f1f authored Jun 20, 2017 by Jarkko Sakkinen Committed by Greg Kroah-Hartman Aug 11, 2017

tpm: fix a kernel memory leak in tpm-sysfs.c



commit 13b47cfcfc60495cde216eef4c01040d76174cbe upstream.

While cleaning up sysfs callback that prints EK we discovered a kernel
memory leak. This commit fixes the issue by zeroing the buffer used for
TPM command/response.

The leak happen when we use either tpm_vtpm_proxy, tpm_ibmvtpm or
xen-tpmfront.

Cc: stable@vger.kernel.org
Fixes: 08837438 ("TPM: sysfs functions consolidation")
Reported-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent beb807ce

drivers/char/tpm/tpm-sysfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -57,6 +57,8 @@ static ssize_t pubek_show(struct device dev, struct device_attribute attr,

		struct tpm_chip *chip = dev_get_drvdata(dev);

		memset(&tpm_cmd, 0, sizeof(tpm_cmd));

		tpm_cmd.header.in = tpm_readpubek_header;
		err = transmit_cmd(chip, &tpm_cmd, READ_PUBEK_RESULT_SIZE,
		"attempting to read the PUBEK");