Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 721a033b authored by Abdulla Anam's avatar Abdulla Anam Committed by Gerrit - the friendly Code Review server
Browse files

msm: vidc: Correct debugfs directory name 



Video instance pointer is used directly as a unique name for
the instance's corresponding debugfs directory. %pK will remove
the uniqueness and hence only first among any concurrent sessions
will be able to create a corresponding debugfs directory. Use %p
as the name is not directly revealed through prints.

Change-Id: I3a79950b76c1c38e487471f21dc60590b032dd3f
Signed-off-by: default avatarAbdulla Anam <abdullahanam@codeaurora.org>
parent 64120cd2

drivers/media/platform/msm/vidc/msm_vidc_debug.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -153,7 +153,7 @@ struct dentry *msm_vidc_debugfs_init_drv(void) 
	struct dentry *f = debugfs_create_##__type(__name, S_IRUGO | S_IWUSR, \

	struct dentry *f = debugfs_create_##__type(__name, S_IRUGO | S_IWUSR, \

		dir, __value);                                                \

		dir, __value);                                                \

	if (IS_ERR_OR_NULL(f)) {                                              \

	if (IS_ERR_OR_NULL(f)) {                                              \

		dprintk(VIDC_ERR, "Failed creating debugfs file '%pKd/%s'\n",  \

		dprintk(VIDC_ERR, "Failed creating debugfs file '%pd/%s'\n",  \

			dir, __name);                                         \

			dir, __name);                                         \

		f = NULL;                                                     \

		f = NULL;                                                     \

	}                                                                     \

	}                                                                     \
@@ -352,7 +352,7 @@ struct dentry *msm_vidc_debugfs_init_inst(struct msm_vidc_inst *inst, 
		dprintk(VIDC_ERR, "Invalid params, inst: %pK\n", inst);

		dprintk(VIDC_ERR, "Invalid params, inst: %pK\n", inst);

		goto failed_create_dir;

		goto failed_create_dir;

	}

	}

	snprintf(debugfs_name, MAX_DEBUGFS_NAME, "inst_%pK", inst);

	snprintf(debugfs_name, MAX_DEBUGFS_NAME, "inst_%p", inst);

	dir = debugfs_create_dir(debugfs_name, parent);

	dir = debugfs_create_dir(debugfs_name, parent);

	if (!dir) {

	if (!dir) {

		dprintk(VIDC_ERR, "Failed to create debugfs for msm_vidc\n");

		dprintk(VIDC_ERR, "Failed to create debugfs for msm_vidc\n");