Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b505d74 authored by Andrey Konovalov's avatar Andrey Konovalov Committed by Dennis Cagle
Browse files

dccp: fix freeing skb too early for IPV6_RECVPKTINFO



In the current DCCP implementation an skb for a DCCP_PKT_REQUEST packet
is forcibly freed via __kfree_skb in dccp_rcv_state_process if
dccp_v6_conn_request successfully returns.

However, if IPV6_RECVPKTINFO is set on a socket, the address of the skb
is saved to ireq->pktopts and the ref count for skb is incremented in
dccp_v6_conn_request, so skb is still in use. Nevertheless, it gets freed
in dccp_rcv_state_process.

Fix by calling consume_skb instead of doing goto discard and therefore
calling __kfree_skb.

Similar fixes for TCP:

fb7e2399 [TCP]: skb is unexpectedly freed.
0aea76d35c9651d55bbaf746e7914e5f9ae5a25d tcp: SYN packets are now
simply consumed

Change-Id: I6a42c0eba27e18e266860f96706ee9027d37f4d6
Signed-off-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Acked-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git


Git-commit: 5edabca9d4cff7f1f2b68f0bac55ef99d9798ba4
Signed-off-by: default avatarDennis Cagle <dcagle@codeaurora.org>
parent a21201d2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment