futex: Replace barrier() in unqueue_me() with READ_ONCE()
commit 29b75eb2d56a714190a93d7be4525e617591077a upstream. Commit e91467ec ("bug in futex unqueue_me") introduced a barrier() in unqueue_me() to prevent the compiler from rereading the lock pointer which might change after a check for NULL. Replace the barrier() with a READ_ONCE() for the following reasons: 1) READ_ONCE() is a weaker form of barrier() that affects only the specific load operation, while barrier() is a general compiler level memory barrier. READ_ONCE() was not available at the time when the barrier was added. 2) Aside of that READ_ONCE() is descriptive and self explainatory while a barrier without comment is not clear to the casual reader. No functional change. [ tglx: Massaged changelog ] Change-Id: I41b0f0c77dc827536685dddb60f32a31c1cde559 Signed-off-by:Jianyu Zhan <nasa4836@gmail.com> Acked-by:
Christian Borntraeger <borntraeger@de.ibm.com> Acked-by:
Darren Hart <dvhart@linux.intel.com> Cc: dave@stgolabs.net Cc: peterz@infradead.org Cc: linux@rasmusvillemoes.dk Cc: akpm@linux-foundation.org Cc: fengguang.wu@intel.com Cc: bigeasy@linutronix.de Link: http://lkml.kernel.org/r/1457314344-5685-1-git-send-email-nasa4836@gmail.com Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Signed-off-by:
Davidlohr Bueso <dbueso@suse.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Git-repo: https://android.googlesource.com/kernel/msm Git-commit: 1920b8a6a6ed80d3a595ff718c0a99c7d4d895c4 Signed-off-by:
Srinivasa Rao Kuppala <srkupp@codeaurora.org>
Loading
Please register or sign in to comment