Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c60b118 authored by Raphael Assenat's avatar Raphael Assenat Committed by Linus Torvalds
Browse files

[PATCH] mbxfb: Fix framebuffer size smaller than requested 



This patch fixes a bug where we obtain a smaller resolution than requested.
(eg: in 640x480, only 639x479 usable pixels).

This was due to 1 being substracted from the xres and yres vars two times:
first in mbxfb.c and then in the macros from reg_bits.h.

This patch removes the minus ones from the mbxfb.c file. Tested and works.

Signed-off-by: default avatarRaphael Assenat <raph@8d.com>
Signed-off-by: default avatarAntonino Daplas <adaplas@pol.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 8bc21841

drivers/video/mbx/mbxfb.c

+4 −4
Original line number Diff line number Diff line
@@ -255,8 +255,8 @@ static int mbxfb_set_par(struct fb_info *info) 


	/* setup resolution */

	gsctrl &= ~(FMsk(GSCTRL_GSWIDTH) | FMsk(GSCTRL_GSHEIGHT));

	gsctrl |= Gsctrl_Width(info->var.xres - 1) |

		Gsctrl_Height(info->var.yres - 1);

	gsctrl |= Gsctrl_Width(info->var.xres) |

		Gsctrl_Height(info->var.yres);

	writel(gsctrl, GSCTRL);

	udelay(1000);
@@ -413,8 +413,8 @@ static void __devinit setup_graphics(struct fb_info *fbi) 
{

	unsigned long gsctrl;



	gsctrl = GSCTRL_GAMMA_EN | Gsctrl_Width(fbi->var.xres - 1) |

		Gsctrl_Height(fbi->var.yres - 1);

	gsctrl = GSCTRL_GAMMA_EN | Gsctrl_Width(fbi->var.xres) |

		Gsctrl_Height(fbi->var.yres);

	switch (fbi->var.bits_per_pixel) {

	case 16:

		if (fbi->var.green.length == 5)