Commit 50d0ac2e authored Nov 16, 2010 by Axel Lin Committed by Mark Brown Nov 16, 2010

ASoC: Fix incorrect kfree in ad193x_probe error path



We allocated memory for ad193x in ad193x_spi_probe,
and will free the memory in either ad193x_spi_probe error path or
ad193x_spi_remove.

Thus we should not call kfree(ad193x) in ad193x_probe, otherwise
we have double free of ad193x.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent af353d8a

sound/soc/codecs/ad193x.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -364,7 +364,6 @@ static int ad193x_probe(struct snd_soc_codec *codec)
	if (ret < 0) {		if (ret < 0) {
	dev_err(codec->dev, "failed to set cache I/O: %d\n",		dev_err(codec->dev, "failed to set cache I/O: %d\n",
	ret);		ret);
	kfree(ad193x);
	return ret;		return ret;
	}		}