Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af353d8a authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

ASoC: Fix incorrect kfree in ad1836_probe error path 



We allocated memory for ad1836 in ad1836_spi_probe,
and will free the memory in either ad1836_spi_probe error path or
ad1836_spi_remove.

Thus we should not call kfree(ad1836) in ad1836_probe, otherwise
we have double free of ad1836.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent ef995e3a

sound/soc/codecs/ad1836.c

+0 −1
Original line number Diff line number Diff line
@@ -228,7 +228,6 @@ static int ad1836_probe(struct snd_soc_codec *codec) 
	if (ret < 0) {

		dev_err(codec->dev, "failed to set cache I/O: %d\n",

				ret);

		kfree(ad1836);

		return ret;

	}